ci: buffer fuzz timeout above max_total_time so libFuzzer self-exits#40
Merged
Conversation
|
Too many files changed? Review this PR in Change Stack to see how the pieces fit before you dive in. WalkthroughUpdated security workflow timeout handling for libFuzzer fuzzing jobs. Quick Fuzz outer timeout increased from 120 to 150 seconds, Deep Fuzz from 28800 to 28980 seconds, both preserving their inner ChangesFuzzing workflow timeout tuning
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
The outer `timeout` wrapping `cargo fuzz run` must exceed -max_total_time. libFuzzer's clock starts after build + corpus-load, so an equal timeout always wins the race and SIGTERMs the process before its graceful "Done" self-exit — every run then logs "run interrupted", making a genuine hang indistinguishable from normal end-of-budget completion. - Quick Fuzz: timeout 120 -> 150 (max_total_time stays 120, +30s slack) - Deep Fuzzing: timeout 28800 -> 28980 (max_total_time stays 28800, +3min slack, within 540min job cap) Exit code 124 (genuine hang killed by timeout) remains tolerated.
27Bslash6
force-pushed
the
ci/fuzz-timeout-buffer
branch
from
cab6ba3 to
81b82ad
Compare
Contributor
Author
|
@coderabbitai approve |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/security.yml:
- Around line 190-197: The shell command using the GitHub Actions template
expansion `${{ matrix.target }}` should be quoted to prevent word-splitting or
injection if the matrix values change; update the timeout/cargo fuzz invocation
(the line calling `timeout 28980 cargo fuzz run ${{ matrix.target }} --
-max_total_time=28800 || [ $? -eq 124 ]`) to wrap the template expansion in
quotes (e.g., use `"$...` around `${{ matrix.target }}`) so the matrix target is
passed as a single argument to `cargo fuzz run`.
- Around line 127-132: Update the shell command that runs fuzzing to quote the
matrix expansion to avoid word-splitting or injection: change the invocation
"timeout 150 cargo fuzz run ${{ matrix.target }} -- -runs=0 -max_total_time=120
|| [ $? -eq 124 ]" so the template expansion is wrapped in double quotes (e.g.
"${{ matrix.target }}"), leaving the rest of the command and the timeout/error
handling unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 68e3bb38-839b-4824-a55b-960bb1548cda
📒 Files selected for processing (1)
.github/workflows/security.yml
✅ Action performedComments resolved and changes approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Widen the outer
timeoutwrappingcargo fuzz runin both the Quick Fuzz and Deep Fuzzing jobs so it sits above libFuzzer's-max_total_time, not equal to it.timeout-max_total_timeWhy
libFuzzer self-exits gracefully at
-max_total_timewith a finalDone N runs+ corpus consolidation. Its clock starts after build + corpus-load, so an equal outertimeoutalways wins the race — it SIGTERMs the process first, every run logsrun interrupted, and a genuine hang becomes indistinguishable from normal end-of-budget completion. The buffer makestimeouta hang safety-net only.Exit code 124 (timeout fired = real hang) remains tolerated.
Notes
ci:type — non-releasing, does not trigger release-please.Summary by CodeRabbit